Conversation
srueg
force-pushed
the
cluster-repo-optional
branch
from
afce1e7 to
7337a0d
Compare
4 tasks
corvus-ch
approved these changes
Oct 1, 2020
Contributor
Author
|
I just realized that with this it's now not possible to create a valid tenant via the API anymore: The API can only set the URL but not the APISecretRef which is not defaulted anymore and therefore stays empty. To solve this we could either add a default to the API again ( |
Contributor
Author
|
As discussed: For now we'll implement a default for the APISecretRef, set via env var. |
tobru
approved these changes
Oct 2, 2020
Together with [1] a tenant can specify a template which will be used for defaults of a new cluster. [1] projectsyn/lieutenant-operator#110
To be able to set a sane default (and nothing hard coded) an environment variable is used.
srueg
force-pushed
the
cluster-repo-optional
branch
from
5b1507f to
a69a2ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with [1] a tenant can specify a template which will be used for
defaults of a new cluster.
[1] projectsyn/lieutenant-operator#110
Checklist