Add logic in Steward to delete bootstrap ArgoCD#198
Merged
Conversation
f1cc631 to
ad0785e
Compare
This commit introduces a new method which deletes the bootstrap ArgoCD resources (`deployments`, `statefulsets` and `services` with label `steward.syn.tools/bootstrap=true`). This method is called once a minute as soon as Steward sees that an `ArgoCD` custom resource is present on the cluster. This should reduce the complexity and brittleness of the cluster bootstrap process by completely encapsulating the responsibility for bootstrap cleanup in Steward, rather than having part of the cleanup in component-argocd.
ad0785e to
e80c170
Compare
bastjan
approved these changes
Jun 4, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new method which deletes the bootstrap ArgoCD resources (
deployments,statefulsetsandserviceswith labelsteward.syn.tools/bootstrap=true). This method is called once a minute as soon as Steward sees that anArgoCDcustom resource is present on the cluster.This should reduce the complexity and brittleness of the cluster bootstrap process by completely encapsulating the responsibility for bootstrap cleanup in Steward, rather than having part of the cleanup in component-argocd.
Additionally, the PR removes the now unnecessary ArgoCD sync-options annotations from the bootstrap ArgoCD resources.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog