Skip to content

Conversation

@bartveneman
Copy link
Member

closes #119

  1. src/parse-selector.ts:136-171 - Modified parse_selector_list to skip TOKEN_COMMENT tokens when looking for commas between selectors
  2. src/parse-selector.test.ts:1278-1310 - Added two test cases covering comments in selector lists

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.94%. Comparing base (466e411) to head (3339ea0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   94.91%   94.94%   +0.02%     
==========================================
  Files          15       15              
  Lines        2596     2611      +15     
  Branches      676      680       +4     
==========================================
+ Hits         2464     2479      +15     
  Misses        132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bartveneman bartveneman merged commit f34be2b into main Jan 4, 2026
5 checks passed
@bartveneman bartveneman deleted the fix/in-between-comment-parsing branch January 4, 2026 18:18
@codecov-commenter
Copy link

Bundle Report

Changes will increase total bundle size by 616 bytes (0.44%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@projectwallace/css-parser-esm 141.46kB 616 bytes (0.44%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @projectwallace/css-parser-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
parse-*.js 616 bytes 25.89kB 2.44%

Files in parse-*.js:

  • ./src/parse-selector.ts → Total Size: 24.47kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser stops parsing selectors after encountering a comment in a selector list

3 participants