fix: Eliminate unsafe manual token position updates in CSS parser#147
Merged
bartveneman merged 2 commits intomainfrom Feb 26, 2026
Merged
fix: Eliminate unsafe manual token position updates in CSS parser#147bartveneman merged 2 commits intomainfrom
bartveneman merged 2 commits intomainfrom
Conversation
Bundle ReportChanges will increase total bundle size by 751 bytes (0.51%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @projectwallace/css-parser-esmAssets Changed:
Files in
Files in
Files in
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 94.85% 94.96% +0.10%
==========================================
Files 16 16
Lines 2704 2721 +17
Branches 709 712 +3
==========================================
+ Hits 2565 2584 +19
+ Misses 139 137 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes position state desynchronization bugs and consolidates position
management into safe, consistent APIs.
Changes:
Add Lexer.skip_whitespace_in_range() method
skipping
Replace manual backtracking with save_position/restore_position API
of
manual pos/line/column restoration
parse_type_or_namespace_selector() and
parse_universal_or_namespace_selector()
backtracking
Fix unsafe whitespace skipping methods
lexer.skip_whitespace_in_range() instead of utility that only
updates pos
Fix unsafe position-only assignments in sub-range parsing
temporary
lexer instead of corrupting main lexer position state
Impact: