Add support for formatting CSS namespace selectors#209
Merged
Conversation
Import is_universal_selector from css-parser and handle the namespace property on both TypeSelector and UniversalSelector nodes, printing the namespace prefix (e.g. ns|div, *|div, |div, ns|*) correctly. https://claude.ai/code/session_01HfazKmPqWt1wtBF3ZUJ53P
Bundle ReportChanges will increase total bundle size by 209 bytes (1.22%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: formatCss-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 96.80% 96.83% +0.03%
==========================================
Files 2 2
Lines 344 348 +4
Branches 124 127 +3
==========================================
+ Hits 333 337 +4
Misses 10 10
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for properly formatting CSS namespace selectors, including type selectors and universal selectors with namespace prefixes.
Key Changes
print_simple_selector()function to handle namespace prefixes for both type selectors (e.g.,ns|div) and universal selectors (e.g.,ns|*)is_universal_selectorutility functionns|div,ns|*)*|div,*|*)|div,|*)ns|div, ns|span)Implementation Details
namespaceproperty and converted to lowercase before being prepended to the selector namenamespaceisnull) are formatted as beforehttps://claude.ai/code/session_01HfazKmPqWt1wtBF3ZUJ53P