Skip to content

Conversation

@genhoi
Copy link
Contributor

@genhoi genhoi commented Jan 19, 2020

I fixed some problem with ci and tests

  1. RabbitMQ is not installed on Xenial Build, therefore ci failed
    https://travis-ci.community/t/rabbitmq-on-xenial/1827
  2. ./vendor/bin/docheader check bin/ config/ src/ tests/ fail, do you have any idea why?
  3. Tests with php-amqplib 2.9 and higher are failed

@genhoi genhoi mentioned this pull request Jan 19, 2020
@genhoi genhoi closed this Jan 19, 2020
@genhoi genhoi reopened this Jan 19, 2020
@prolic
Copy link
Owner

prolic commented Jan 26, 2020

Thanks

  1. Cool, accepted
  2. Look for copyright year, most likely it just has to be updated to 2020.
  3. I created a new issue here Support php-amqplib >=2.9 #81

@genhoi
Copy link
Contributor Author

genhoi commented Jan 28, 2020

  1. Copyright year - updated and enable docheader check

@prolic prolic merged commit 210f4f2 into prolic:master Feb 3, 2020
@prolic
Copy link
Owner

prolic commented Feb 3, 2020

Thanks a lot, sorry I'm quite slow to respond these days. Will be better soon.

@genhoi genhoi deleted the fix-ci-tests branch February 3, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants