Skip to content

Conversation

@rppgorecki
Copy link
Contributor

Console actions ready for symfony/console 5.*

Execute command should return int, if not error is thrown:

PHP Fatal error: Uncaught TypeError: Return value of "Humus\Amqp\Console\Command\ShowCommand::execute()" must be of the type int, NULL returned. in /var/www/html/vendor/symfony/console/Command/Command.php:258

@prolic
Copy link
Owner

prolic commented Feb 28, 2020

@rppgorecki see https://github.com/prolic/HumusAmqp/blob/master/composer.json#L21

Console v5 isn't even allowed as of now. If nothing else breaks, we can try to enable support for v4 and v5 as well, but that should at least be tested first.

@rppgorecki
Copy link
Contributor Author

@prolic I've updated composer.json - all checks have passed (It's really simple change, but needed if you use newer symfony/console in your project)

@prolic prolic merged commit 27a6d3b into prolic:master Mar 5, 2020
@prolic
Copy link
Owner

prolic commented Mar 5, 2020

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants