#22 Add events on Consumer and RpcServer#23
Closed
thomasvargiu wants to merge 4 commits intoprolic:masterfrom
thomasvargiu:HumusAmqpModule-22
Closed
#22 Add events on Consumer and RpcServer#23thomasvargiu wants to merge 4 commits intoprolic:masterfrom thomasvargiu:HumusAmqpModule-22
thomasvargiu wants to merge 4 commits intoprolic:masterfrom
thomasvargiu:HumusAmqpModule-22
Conversation
Contributor
Author
|
What do you think? |
Owner
|
Thank you very much for your contribution. The event system would also help to implement automatic serialization and encoding of the message (see #16). |
Owner
There was a problem hiding this comment.
The supervisor module should not be a hard dependency on the module, as this module works only on unix systems. So this would mean you cannot use the amqp module on windows platforms anymore.
Contributor
Author
There was a problem hiding this comment.
Just an error, we need it in require-dev. I'll move it.
Owner
|
Looks good, I need to do some tests first, merge will happen the next days. Thank you! |
prolic
added a commit
that referenced
this pull request
Nov 10, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented events in consumer class.
Logger is not a consumer dependency anymore.
Callbacks and logger are not required, but compatible with the old configuration.
The result for deliveryCallback is the return value of the last listener. It's possible to set the right priorities or to stop execution in the listener.
I've done some little refactoring and tests.