Fix pcntl typo#29
Merged
prolic merged 1 commit intoprolic:masterfrom Jan 8, 2015
Merged
Conversation
prolic
added a commit
that referenced
this pull request
Jan 8, 2015
Owner
|
Thanks man! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using the
humus amqp consumercommand when this exception has been thrown with the wrong pcntl extension name.I would suggest to add it into the Dependencies list in the readme (marked as optional) since, also if its a built-in ext, is not assured that PHP was compiled including it and the operating system supports it.
Anyhow thank you for this module! 😉