Skip to content

PSR 3 Log#37

Merged
prolic merged 1 commit intoprolic:masterfrom
thomasvargiu:psr-log
May 16, 2016
Merged

PSR 3 Log#37
prolic merged 1 commit intoprolic:masterfrom
thomasvargiu:psr-log

Conversation

@thomasvargiu
Copy link
Copy Markdown
Contributor

Instead to use Zend/Log, now it's possibile to use another PSR 3 compatible logger now.

  • Added PSR 3 compatibility
  • Dropped support for php 5.4
  • Added composer scripts

Can we consider it to be merged for 0.2.0?
I also would like to do some work to use container-interop and reduce other hard dependencies.

Composer scripts

Fix 5.4 incompatible ::class in tests

Tests for invalid psr log exception

zend-log min version fix

Dropped support for php 5.4
@prolic
Copy link
Copy Markdown
Owner

prolic commented May 15, 2016

Looks good on first sight. Will do a better review tomorrow.
I can release 0.2.0 soon, but for 1.0.0 there will be pretty much everything removed and depended on HumusAmqp instead. So the HumusAmqpModule will only be an addon for zf2 module manager integration.
Container interop is also coming from within HumusAmqp, along with container config interop.
There is however the question whether there will be a logger support or maybe it's better to just trigger events (zf3 event manager???) and let listeners handle logging. Thoughts?

@prolic prolic merged commit a5bcfa0 into prolic:master May 16, 2016
@prolic
Copy link
Copy Markdown
Owner

prolic commented May 21, 2016

For now there will be no event manager integration, only a logger.
A change may come when there is enough need and feature requests for it.

@thomasvargiu thomasvargiu deleted the psr-log branch May 26, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants