ci(DCP-2583): build in create-release workflow#420
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates release creation and binary build/upload into a single GitHub Actions workflow (create-release.yml) by deleting the standalone release.yml workflow and adding a new build job that runs after release finalization.
Changes:
- Removed
.github/workflows/release.ymland migrated its build/upload logic intocreate-release.yml. - Added a
buildjob that checks out the newly created tag and uploads multi-platform binaries to the GitHub release. - Updated
actions/setup-gousage in the workflow tov6.4.0and wired the release tag as a job output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Deleted legacy workflow that built/uploaded release binaries on release.published. |
| .github/workflows/create-release.yml | Added tag output + new build job to build/upload binaries as part of the release creation pipeline. |
e0f57aa to
56ac059
Compare
ffucile
reviewed
Apr 13, 2026
ffucile
reviewed
Apr 13, 2026
ffucile
reviewed
Apr 13, 2026
ffucile
reviewed
Apr 13, 2026
ffucile
reviewed
Apr 13, 2026
ffucile
reviewed
Apr 13, 2026
b88a733 to
7f8cbc7
Compare
script-this
previously approved these changes
Apr 13, 2026
| GOOS=${GOOSARCH%/*} | ||
| ARCH=${GOOSARCH#*/} | ||
|
|
||
| echo "\n\nBuilding binary for ${GOOS}/${ARCH}\n" |
Contributor
There was a problem hiding this comment.
Purely cosmetic but won't interpret these as newlines in bash I don't think.
script-this
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and simplifies the release automation workflow, moving from a PR-title-based trigger (
[run-release]) to a label-based trigger (release). It consolidates and streamlines CI gates, updates documentation to match the new process, and merges the build and release steps for improved reliability and clarity.Release workflow improvements:
releaselabel to a PR, rather than adding[run-release]to the PR title. This change is reflected in both workflow files and documentation. [1] [2] [3] [4] [5] [6]release-tag-gate.ymlandrelease.ymlworkflows have been removed, consolidating checks and builds into a single streamlined process. [1] [2]CI gate and workflow changes:
changelog-gate.ymlworkflow now checks for thereleaselabel instead of[run-release]in the PR title, and only fails if the label is present butCHANGELOG.mdis not modified. [1] [2]create-release.ymlworkflow now runs on pushes tomain, checks merged PRs for thereleaselabel, creates a tag and GitHub Release, and immediately builds and uploads binaries for all platforms. [1] [2] [3]Documentation updates:
DEVELOPMENT.mdandREADME.mdnow reference thereleaselabel workflow, removing references to[run-release]in PR titles and the old validation gates. [1] [2] [3]Summary of most important changes:
Release workflow and CI changes:
[run-release]PR title tag toreleaselabel; update all workflows and documentation accordingly. [1] [2] [3] [4]release-tag-gate.ymlandrelease.ymlworkflows, consolidating checks and builds intocreate-release.yml. [1] [2]changelog-gate.ymlto check for thereleaselabel and requireCHANGELOG.mdmodification only when the label is present.Build and release process:
create-release.yml, add a job to check merged PRs for thereleaselabel, then create a tag, GitHub Release, and build/upload binaries for all platforms in one workflow. [1] [2] [3]Documentation and developer experience:
DEVELOPMENT.mdandREADME.mdto describe the new label-based release process, improve formatting, and fix links. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]