fix(DCP-2903): upgrade Go to 1.26.3 for std/net CVE fixes#431
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cd42180 to
30b22c0
Compare
benmatselby
previously approved these changes
May 12, 2026
benmatselby
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Go toolchain 1.26.1 → 1.26.3 to remediate two Snyk-reported high-severity stdlib vulnerabilities. Includes two small unrelated unblockers needed for CI to go green (see "Scope creep" below).
Jira: DCP-2903 (parent: DCP-914)
CVEs fixed
net.LookupCNAMEvia cgo resolverSETTINGS_MAX_FRAME_SIZE=0Both fixes ship in Go 1.26.3 (2026-05-07).
This binary builds with
CGO_ENABLED=1, so the cgo-resolver path in CVE-2026-33811 is reachable — the upgrade fixes a materially vulnerable code path, not just a Snyk score.Commits
fix(DCP-2903): upgrade Go to 1.26.3 for std/net CVE fixesgo.mod:go 1.26.1→go 1.26.3;Dockerfile:golang:1.26.1-alpine→golang:1.26.3-alpine. CI workflows already use1.26.xglob — no change.ci(DCP-2903): pin golangci-lint to v2.11.2 in CI and local installtest(DCP-2903): sync contract test with updated openapi specScope creep (why two extra commits)
1.
golangci-lintversion pin (v2.11.2).github/workflows/go.ymlwas usingversion: latestforgolangci-lint-action. golangci-lint 2.12 (released 2026-05-06) introduced new analyzers (govet inline, strictergoconst) that flag pre-existing code throughout the repo (slices.Containscalls, repeated test-string literals). Every PR opened against main today fails the lint job for the same reason — main itself would also be red on re-run.Pinning both CI (
.github/workflows/go.yml) and local install (Makefile) tov2.11.2(the last known-green version) restores deterministic lint behaviour. A follow-up ticket should be filed to address the underlying lint debt and re-evaluate the pin.2. Contract test sync
make testrunscontract_test/, which downloadshttps://docs.prolific.com/openapi.yamlfresh each run and validates client calls against it. The Prolific public API spec has changed since047d6af(when the contract test was added):get-submission-demographicsoperation was removed, andexternal_study_urlis now required oncreate-study. The test correctly flagged this drift — but main hasn't been re-run, so it's currently broken on main too. Synced the test fixtures to match today's spec.Test plan
make buildsucceeds (Go auto-downloaded 1.26.3 toolchain)make test— all packages pass includingcontract_test/make lint— 0 issues (with pinned v2.11.2)go version ./prolificreportsgo1.26.3go version -m ./prolificconfirmsCGO_ENABLED=1(vulnerable path exists, now patched)