Skip to content

Conversation

@asherf
Copy link
Member

@asherf asherf commented Jun 15, 2019

Allow non-superuser commands to be re-run without (some) errors.

Based on @michaelkaye PR #247
I just resolved the merged conflicts on the original PR.
@baburdick FYI (I am happy to incorporate any feedback you may have as I am new to postgres)

Allow non-superuser commands to be re-run without (some) errors.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.844% when pulling 9d19b96 on asherf:doc-update into 07dd31d on wrouesnel:master.

@baburdick
Copy link

@asherf: This looks like an improvement on #247.

Neither of these addresses the CREATE ROLE failure. But that's no reason not to merge this.

This appears to be the best answer on how to handle that without introducing a race condition: https://stackoverflow.com/a/55954480

@wrouesnel wrouesnel merged commit b12adc1 into prometheus-community:master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants