WIP: Bugfixes and upgrades #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the postgres_exporter WIP port for Prometheus and avoids the by default collision with the nginx_exporter. Closes #22.
This PR is not general to all versions of postgres, and in the worst case meant the query returned nothing. Closes #30 and shows we need a test case.
Similar to the node_exporter, this key is synthetic and used to create a constant metric which records the version strings of PostgreSQL in its labels.
Use docker-compose and p2 to setup a replicated environment for each version of PostgreSQL we want to support. Still missing: key-specific tests to ensure each version doesn't lose metrics.
This puts us on the road to dropping the bash tests and doing it all in Go.
…uite. This is the first step in moving the integration test suite to a more reliable Golang based one.
wrouesnel
force-pushed
the
bugfixes_and_upgrades
branch
from
c721980 to
1246d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolutions to a whole bunch of outstanding issues I've left for far too long.
The key change being made here is a significant upgrade to the testing infrastructure to stamp out some of the issues this exporter has had. We will now be running Travis builds which test every version of postgres, in replicated and non-replicated mode, and which do a deep inspection on the internals via an integration test binary.
Resolves #29 by the improvements in the replication queries.
Resolves #16 with Postgres version checking support.