Skip to content

Conversation

@haibeey
Copy link
Contributor

@haibeey haibeey commented May 31, 2020

This PR introduces Fuzzy completion matching for Function names,Label values, Label names and Aggregators.

@slrtbtfs
Copy link
Member

slrtbtfs commented Jun 1, 2020

@haibeey FYI: The linter errors are visible like code comments in the "Files Changed" tab of the PR.

@haibeey haibeey force-pushed the master branch 2 times, most recently from 4c1af61 to a77563f Compare June 1, 2020 15:48
@haibeey
Copy link
Contributor Author

haibeey commented Jun 1, 2020

@slrtbtfs have look

@slrtbtfs
Copy link
Member

slrtbtfs commented Jun 1, 2020

The append in Line 470 should use the suggested syntax, otherwise LGTM.

…s and Aggregators.

Signed-off-by: akerele abraham <abrahamakerele38@gmail.com>
@slrtbtfs
Copy link
Member

slrtbtfs commented Jun 1, 2020

Thanks!

@slrtbtfs slrtbtfs merged commit 3992a10 into prometheus-community:master Jun 1, 2020
@Nexucis
Copy link
Contributor

Nexucis commented Jun 2, 2020

PR closed the issue #128

@Nexucis Nexucis mentioned this pull request Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants