Skip to content

Add support for AuthSecret from file#3087

Merged
SuperQ merged 3 commits intoprometheus:mainfrom
Git-Jiro:implement_secrets_from_file
Jan 8, 2026
Merged

Add support for AuthSecret from file#3087
SuperQ merged 3 commits intoprometheus:mainfrom
Git-Jiro:implement_secrets_from_file

Conversation

@Git-Jiro
Copy link
Contributor

@Git-Jiro Git-Jiro commented Oct 1, 2022

related to: #2498

@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch 2 times, most recently from 90a46c2 to 614850c Compare October 1, 2022 10:35
@simonpasquier
Copy link
Member

Something's weird with CircleCI reporting Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.... Have you enabled CircleCI on your fork repository?

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 3, 2022

I am not aware of doing any Circle CI related stuff on my fork. I just forked and worked on the fix.

@OktarianTB
Copy link
Contributor

Documentation is not up to date with regards to auth_password_file nor auth_secret_file.

@TheMeier
Copy link
Contributor

@Git-Jiro can you rebase this PR?

@Git-Jiro
Copy link
Contributor Author

@TheMeier sure!

@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch from 614850c to 01393a2 Compare November 15, 2025 19:21
@TheMeier
Copy link
Contributor

@Git-Jiro can you also pleas sign-off your commits. See https://github.com/prometheus/alertmanager/pull/3087/checks?check_run_id=55492475887

@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch 2 times, most recently from 1a3d200 to 00b2b05 Compare November 19, 2025 19:36
@TheMeier
Copy link
Contributor

Sorry to bother you again @Git-Jiro but this would need another re-base :(

Signed-off-by: Martin Schimandl <martin.schimandl@gmail.com>
Signed-off-by: Martin Schimandl <martin.schimandl@gmail.com>
@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch from 00b2b05 to a4938aa Compare December 14, 2025 10:41
@Git-Jiro
Copy link
Contributor Author

@TheMeier done :-)

@SuperQ
Copy link
Member

SuperQ commented Jan 5, 2026

Sorry again, needs a rebase. 😢

Signed-off-by: Martin Schimandl <martin.schimandl@gmail.com>
@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch from 03b0fd2 to c60dc82 Compare January 7, 2026 17:59
@SuperQ SuperQ merged commit 9b4c6dd into prometheus:main Jan 8, 2026
7 checks passed
@SoloJacobs SoloJacobs mentioned this pull request Jan 29, 2026
SuperQ added a commit that referenced this pull request Feb 2, 2026
* [ENHANCEMENT] docs(opsgenie): Fix description of `api_url` field. #4908
* [ENHANCEMENT] docs(slack): Document missing app configs. #4871
* [ENHANCEMENT] docs: Fix `max-silence-size-bytes`. #4805
* [ENHANCEMENT] docs: Update expr for `AlertmanagerClusterFailedToSendAlerts` to exclude value 0. #4872
* [ENHANCEMENT] docs: Use matchers for inhibit rules examples. #4131
* [ENHANCEMENT] docs: add notification integrations. #4901
* [ENHANCEMENT] docs: update `slack_config` attachments documentation links. #4802
* [ENHANCEMENT] docs: update description of filter query params in openapi doc. #4810
* [ENHANCEMENT] provider: Reduce lock contention. #4809
* [FEATURE] slack: Add support for top-level text field in slack notification. #4867
* [FEATURE] smtp: Add support for authsecret from file. #3087
* [FEATURE] smtp: Customize the ssl/tls port support (#4757). #4818
* [FEATURE] smtp: Enhance email notifier configuration validation. #4826
* [FEATURE] telegram: Add `chat_id_file` configuration parameter. #4909
* [FEATURE] telegram: Support global bot token. #4823
* [FEATURE] webhook: Support templating in url fields. #4798
* [FEATURE] wechat: Add config directive to pass api secret via file. #4734
* [FEATURE] provider: Implement per alert limits. #4819
* [BUGFIX] Allow empty `group_by` to override parent route. #4825
* [BUGFIX] Set `spellcheck=false` attribute on silence filter input. #4811
* [BUGFIX] jira: Fix for handling api v3 with ADF. #4756
* [BUGFIX] jira: Prevent hostname corruption in cloud api url replacement. #4892
---------

Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants