Add support for AuthSecret from file #3087
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git-Jiro
force-pushed
the
implement_secrets_from_file
branch
2 times, most recently
from
90a46c2 to
614850c
Compare
simonpasquier
approved these changes
Oct 3, 2022
Member
|
Something's weird with CircleCI reporting |
Contributor
Author
|
I am not aware of doing any Circle CI related stuff on my fork. I just forked and worked on the fix. |
Contributor
|
Documentation is not up to date with regards to |
Contributor
|
@Git-Jiro can you rebase this PR? |
Contributor
Author
|
@TheMeier sure! |
Git-Jiro
force-pushed
the
implement_secrets_from_file
branch
from
614850c to
01393a2
Compare
Contributor
|
@Git-Jiro can you also pleas sign-off your commits. See https://github.com/prometheus/alertmanager/pull/3087/checks?check_run_id=55492475887 |
Git-Jiro
force-pushed
the
implement_secrets_from_file
branch
2 times, most recently
from
1a3d200 to
00b2b05
Compare
TheMeier
approved these changes
Dec 11, 2025
Contributor
|
Sorry to bother you again @Git-Jiro but this would need another re-base :( |
Signed-off-by: Martin Schimandl <martin.schimandl@gmail.com>
Signed-off-by: Martin Schimandl <martin.schimandl@gmail.com>
Git-Jiro
force-pushed
the
implement_secrets_from_file
branch
from
00b2b05 to
a4938aa
Compare
Contributor
Author
|
@TheMeier done :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #2498