Allow to determine which alerts' label would be sorted #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Things affecting notification templating shouldn't leak outside notification templating. Why do you want this? |
Author
|
I don't believe it is fair to be hardcoded the labels that alerts is being sorted |
Author
|
I forgot to say that the sorting is reversed on master, in my humble option the way I did is the most appropriate, but if you believe it is worthwhile the sorting direction could be configurable as well. |
Contributor
|
@tiagoapimenta the sorting is fixed in #1339 |
Contributor
|
this would resolve #1178 I think |
Member
|
Hello from the Alertmanager bug scrub. This change is stale so it will be closed. If you would like to continue this work, please open a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow user to determine which label will be used for sorting