Add the ability to configure slack markdown field#1967
Merged
simonpasquier merged 4 commits intoprometheus:masterfrom Jul 31, 2019
Merged
Add the ability to configure slack markdown field#1967simonpasquier merged 4 commits intoprometheus:masterfrom
simonpasquier merged 4 commits intoprometheus:masterfrom
Conversation
Contributor
stuartnelson3
left a comment
stuartnelson3
left a comment
There was a problem hiding this comment.
Looks good to me. Could you add a test to config/notification_test.go?
https://github.com/prometheus/alertmanager/blob/master/config/notifiers_test.go
Signed-off-by: Asher Foa <asher@asherfoa.com>
asherf
force-pushed
the
slack
branch
2 times, most recently
from
78b4179 to
3c06e65
Compare
Signed-off-by: Asher Foa <asher@asherfoa.com>
Contributor
Author
|
I am happy to add more test cases or more tests for this if this is need.... |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Member
|
Thanks! |
DuskEagle
pushed a commit
to DuskEagle/alertmanager
that referenced
this pull request
Aug 1, 2019
* slack markdown field config Signed-off-by: Asher Foa <asher@asherfoa.com> * Add Test Signed-off-by: Asher Foa <asher@asherfoa.com> * remove empty lines Signed-off-by: Asher Foa <asher@asherfoa.com> * add empty line Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
But everybody forgot to add this to documentation :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1220.