Make filter labels consistent with Prometheus#2403
Merged
Conversation
Filtering the alert out when the label is missing precludes a possible match for an empty value. This change allows the match to be evaluated. Closes prometheus#2342 Signed-off-by: Victor Araujo <vear91@gmail.com>
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
Thanks! Could you add tests for this? At least for api/v2, api/v1 being deprecated I'd be ok without it.
vears91
force-pushed
the
issue-2342
branch
4 times, most recently
from
ce59eb4 to
1027f78
Compare
Signed-off-by: Victor Araujo <vear91@gmail.com>
Contributor
Author
|
Added tests 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtering the alert out when the label is missing precludes a
possible match for an empty value. This change allows the
match to be evaluated.
Closes #2342
Signed-off-by: Victor Araujo vear91@gmail.com