Use UTC when rendering alert and silence dates #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the behaviour of the Alertmanager UI, which converts the inputed string into UTC. This is better because otherwise you get mixed timezones in the string representations when you query the /api/v2/silences endpoint, for instance. It is also more "correct" because Alertmanager uses UTC for presenting and updating dates, and so amtool should do the same. Signed-off-by: Thomas Bregolin <tbregolin@cloudflare.com>
roidelapluie
approved these changes
Dec 24, 2020
Member
|
I'm confused how it changes anything to the current implementation. AFAICT this PR would only change the representation of what's being sent to the API. |
Member
|
it means that the bug is that we do not convert the date when returning it to the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the behaviour of the Alertmanager UI, which converts the
inputed string into UTC. This is better because otherwise you get mixed
timezones in the string representations when you query the
/api/v2/silences endpoint, for instance. It is also more "correct"
because Alertmanager uses UTC for presenting and updating dates, and so
amtool should do the same.