feat: added newrelic receiver #2637

haihongren · 2021-06-28T15:02:00Z

Hey guys

I am working for New Relic. I have added the code for the newrelic receiver.
Could you please review the PR and advise me the next step.

Thanks,
Haihong

haihongren · 2021-06-30T04:33:08Z

Hi @beorn7

I found your name from other PR. Could you please help to review this PR?

It passed all tests except "test_frontend". I think it is related to the change to "template/default.tmpl". Not sure how to fix it on my end. My local test passed successfully.

Thanks in advance!
Haihong

beorn7 · 2021-06-30T10:00:59Z

Thanks for your contribution.

However, I'm not the maintainer of this repo. I helped a bit on a best effort basis, but right now, I have zero time left to do things here.

@simonpasquier could you look at this or delegate?

haihongren · 2021-07-02T04:35:14Z

Thanks @beorn7

@simonpasquier Please advise when you have a chance. Thanks!

config/notifiers.go

roidelapluie

I would review this later, in the mean time I have added a comment. it also seems that the documentation is completely missing.

haihongren · 2021-08-05T02:16:06Z

I would review this later, in the mean time I have added a comment. it also seems that the documentation is completely missing.

@roidelapluie Thanks for pointing out the missing documentation. How do I provide the documentation? in what format?

roidelapluie · 2021-08-06T10:47:02Z

In markdown, in the docs/ directory

haihongren · 2021-08-17T00:24:47Z

@roidelapluie The New Relic receiver documentation is included in docs/configuration.md now. Thanks!

haihongren · 2021-10-26T06:42:23Z

@roidelapluie One of the customers really wants to have this feature merged into the master so that they could use in production. Could you please review at your earliest? Thanks.

RichiH · 2021-10-27T08:44:20Z

As a side note, could you please sign the DCO, @haihongren ?

haihongren · 2021-10-31T23:29:53Z

@RichiH Thanks for the comment. DCO signed for the commit.

roidelapluie · 2021-11-10T17:31:24Z

is it possible to have a test account at NR to test this?

haihongren · 2021-11-15T11:16:49Z

@roidelapluie I have added prometheus-team email address as an NR user. You should receive an email invite at the prometheus-team email account.

haihongren · 2021-12-01T05:44:18Z

@roidelapluie Is there anything else you need to proceed with the PR?

roidelapluie · 2021-12-06T21:17:12Z

Thanks! I finally have some time to dig into this.

Do you know how I can create an API key that works? I currently get 403 with the key I created.

roidelapluie · 2021-12-06T21:17:27Z

I also wonder if we should use the logs api or the incidents API.

config/notifiers.go

docs/configuration.md

notify/newrelic/newrelic.go

Signed-off-by: haihongren <haihong.ren@gmail.com>

haihongren · 2023-07-24T07:27:58Z

I also wonder if we should use the logs api or the incidents API.

@roidelapluie Logs api allows user to collect alerts, generate report/dashboard for alerts, even take further action if required.

I would avoid that and add the ability to pass the license key explicitly. We should not put that burden to users.
@roidelapluie agreed. I removed the Headers setting option. User will use api_key to provide license key explicitly.

Signed-off-by: haihongren <haihong.ren@gmail.com>

Conejsksk · 2023-08-09T10:34:50Z

Hi guys, any update on this?

haihongren · 2023-10-04T23:38:34Z

Hi, can someone please review the PR? thanks

siavashs

Is this PR still valid? If yes, please rebase and address the comments.

siavashs · 2025-10-31T15:29:10Z

notify/newrelic/newrelic.go

+	}, nil
+}
+
+type NewRelicCreateMessage struct {


This type is not exported.

Suggested change

type NewRelicCreateMessage struct {

type newRelicMessage struct {

siavashs · 2025-10-31T15:30:43Z

docs/configuration.md

+- `<duration>`: a duration matching the regular expression `((([0-9]+)y)?(([0-9]+)w)?(([0-9]+)d)?(([0-9]+)h)?(([0-9]+)m)?(([0-9]+)s)?(([0-9]+)ms)?|0)`, e.g. `1d`, `1h30m`, `5m`, `10s`
+- `<labelname>`: a string matching the regular expression `[a-zA-Z_][a-zA-Z0-9_]*`
+- `<labelvalue>`: a string of unicode characters
+- `<filepath>`: a valid path in the current working directory
+- `<boolean>`: a boolean that can take the values `true` or `false`
+- `<string>`: a regular string
+- `<secret>`: a regular string that is a secret, such as a password
+- `<tmpl_string>`: a string which is template-expanded before usage
+- `<tmpl_secret>`: a string which is template-expanded before usage that is a secret
+- `<int>`: an integer value
+- `<regex>`: any valid [RE2 regular expression](https://github.com/google/re2/wiki/Syntax) (The regex is anchored on both ends. To un-anchor the regex, use `.*<regex>.*`.)


Seems unnecessary to change the format of the bullet points.

siavashs · 2025-10-31T15:35:26Z

docs/configuration.md

  [ wechat_api_secret: <secret> ]
  [ wechat_api_corp_id: <string> ]
+  [ newrelic_api_key: <secret> ] New Relic Insert API key
+  [ newrelic_api_url: <string> | default = "https://log-api.newrelic.com/log/v1" ]


This API endpoint seems to be dedicated for sending logs, nothing wrong with logging alerts but is this still a valid API endpoint to send alert messages to or is there now a dedicated endpoint for alerts?

siavashs · 2025-10-31T15:35:58Z

docs/configuration.md

  # All alerts that do not match the following child routes
  # will remain at the root node and be dispatched to 'default-receiver'.
  routes:
-  # All alerts with service=mysql or service=cassandra


Unnecessary reformatting.

siavashs · 2025-10-31T15:36:25Z

docs/configuration.md

-time_intervals:
-  [ - <time_interval_spec> ... ]
+time_intervals: [- <time_interval_spec> ...]


Unnecessary reformatting.
Not going to point out the rest, make sure to remove them.

siavashs · 2025-10-31T15:38:54Z

notify/newrelic/newrelic.go

+type NewRelicCloseMessage struct {
+	Source string `json:"source"`
+}


Why is this needed?

haihongren force-pushed the main branch 2 times, most recently from cf7b479 to 034ef2c Compare June 30, 2021 01:46

roidelapluie reviewed Aug 3, 2021

View reviewed changes

config/notifiers.go Outdated Show resolved Hide resolved

roidelapluie reviewed Aug 3, 2021

View reviewed changes

stale bot added the stale label Oct 16, 2021

stale bot removed the stale label Oct 26, 2021

haihongren force-pushed the main branch from 30319c6 to 1e296ef Compare October 31, 2021 23:27

roidelapluie reviewed Dec 6, 2021

View reviewed changes

stale bot added the stale label Feb 5, 2022

haihongren added 2 commits July 24, 2023 15:46

feat: added newrelic receiver

19c485c

Signed-off-by: haihongren <haihong.ren@gmail.com>

docs: including New Relic receiver documentation

1746128

Signed-off-by: haihongren <haihong.ren@gmail.com>

haihongren force-pushed the main branch 3 times, most recently from 5266a3e to 68f90b9 Compare July 24, 2023 07:17

haihongren force-pushed the main branch from 68f90b9 to aba125a Compare July 24, 2023 07:38

chores: remove 'Headers' from config, cleanup and update docs

f4aafc3

Signed-off-by: haihongren <haihong.ren@gmail.com>

haihongren force-pushed the main branch from aba125a to f4aafc3 Compare July 24, 2023 08:13

haihongren requested a review from roidelapluie October 4, 2023 23:38

siavashs suggested changes Oct 31, 2025

View reviewed changes

SoloJacobs added help wanted component/notify labels Dec 12, 2025

SoloJacobs self-assigned this Dec 12, 2025

	type NewRelicCreateMessage struct {
	type newRelicMessage struct {

feat: added newrelic receiver #2637

Are you sure you want to change the base?

feat: added newrelic receiver #2637

Uh oh!

Conversation

haihongren commented Jun 28, 2021

Uh oh!

haihongren commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

beorn7 commented Jun 30, 2021

Uh oh!

haihongren commented Jul 2, 2021

Uh oh!

Uh oh!

roidelapluie left a comment

Choose a reason for hiding this comment

Uh oh!

haihongren commented Aug 5, 2021

Uh oh!

roidelapluie commented Aug 6, 2021

Uh oh!

haihongren commented Aug 17, 2021

Uh oh!

haihongren commented Oct 26, 2021

Uh oh!

RichiH commented Oct 27, 2021

Uh oh!

haihongren commented Oct 31, 2021

Uh oh!

roidelapluie commented Nov 10, 2021

Uh oh!

haihongren commented Nov 15, 2021

Uh oh!

haihongren commented Dec 1, 2021

Uh oh!

roidelapluie commented Dec 6, 2021

Uh oh!

roidelapluie commented Dec 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haihongren commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Conejsksk commented Aug 9, 2023

Uh oh!

haihongren commented Oct 4, 2023

Uh oh!

siavashs left a comment

Choose a reason for hiding this comment

Uh oh!

siavashs Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

siavashs Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

siavashs Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

siavashs Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

siavashs Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

siavashs Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

haihongren commented Jun 30, 2021 •

edited

Loading

haihongren commented Jul 24, 2023 •

edited

Loading