-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add googlechat notifier #3554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ce01e14 to
808d8cd
Compare
|
Nice! Thanks @tamcore - Do you have any stats on downloads/usage over the past 6 months? I can see that it has a decent number of stars but would love to know more about the usage itself. |
|
Not really. But according to https://github.com/mr-karan/calert/pkgs/container/calert/64363789?tag=v2.0.6 the latest release had 39353 downloads during the 9 months since release. But there's definitely some interest, and at our company we use it as well (but only one of those 39353 pulls is from us - we use an image cache :D) |
06b63fb to
dee0b99
Compare
|
@simonpasquier / @gotjosh any chance to get this included? :) |
|
I would like to see this included. Running external service for simple notifications is a pain in the back. This change doesn't look so dramatic, it should be merged relatively easily... |
dee0b99 to
ab737b9
Compare
|
It shows the error: |
|
Hey folks 👋 |
|
It looks like something similar to this MSTeams code needs to be added in config/config.go: https://github.com/prometheus/alertmanager/blob/main/config/config.go#L535-L542 |
9bc26dd to
3a06e45
Compare
Signed-off-by: Philipp Born <git@pborn.eu>
3a06e45 to
7f46191
Compare
|
Hello, Any infos when this PR could be merged ? :D |
|
@simonpasquier / @gotjosh / @w0rm / @grobinson-grafana any chances? :) |
|
Hey there! |
|
+1 |
siavashs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems still valid, left a suggestion.
Please rebase and update.
| // Message represents the structure for sending a | ||
| // Text message in Google Chat Webhook endpoint. | ||
| // https://developers.google.com/chat/api/guides/message-formats/basic | ||
| type Message struct { | ||
| Text string `json:"text"` | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be extended to support Cards v2: https://developers.google.com/workspace/chat/api/reference/rest/v1/cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please give as an option to send text messages first 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cards are just attachments to a message, it is not a replacement.
One can choose to send text, card or both.
|
I'm sorry, I don't feel like further rebasing or even extending this, until there is a clear sign this will get approval. |
|
Hi @tamcore , currently the process for adding new integrations is not straightforward and I apologize for that. That being said, we do generally accept these types of requests now. Is it possible for you to spend some time providing community support? By answering questions about issues opened by users relating to your integration. In return, I commit to providing speedy reviews and will advocate for the inclusion of your PRs. Thank you very much for your time and potential contribution! Kind regards, Solomon Jacobs |
This will add a Google Chat notifier and allow existing setups to replace the slightly aged calert with a native integration.
Essentially all that's required is to send a POST with
{"text": "our alert"}, so there isn't too much breakage potential :D#2940 2940