Move old parser into matcher package #3995
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/move-pkg-labels-1
branch
3 times, most recently
from
508116e to
62546fe
Compare
Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/move-pkg-labels-1
branch
from
62546fe to
1819ad4
Compare
Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/move-pkg-labels-1
branch
from
1819ad4 to
4604a33
Compare
SuperQ
requested changes
Nov 20, 2024
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Needs a rebase to pickup the slog migration changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of two pull requests that removes matchers from the deprecated
pkg/labelspackage and into the new matcher package.It moves the old regex parser that is known as classic mode into a package called
oldparse. This package will be deleted in future when classic mode is removed.