chore: rephrase classic mode enabled log message #4341
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joobisb <joobisb@gmail.com>
| case FeatureClassicMode: | ||
| opts = append(opts, enableClassicMode()) | ||
| logger.Warn("Classic mode enabled") | ||
| logger.Warn("UTF-8 strict mode is disabled; non-UTF-8 characters will be accepted") |
Collaborator
There was a problem hiding this comment.
This doesn't quite explain what classic mode does, as it's more then UTF-8 strict mode being disabled. Let me take a look at the Mimir issue to see how we can help here because "classic mode" is documented in the Alertmanager UTF-8 migration guide for over 12 months now, and I don't want to create additional confusion renaming bits of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes grafana/mimir#10449