Conversation
SuperQ
force-pushed
the
superq/promauto
branch
from
6fb68b2 to
107ab3d
Compare
Member
Author
SuperQ
force-pushed
the
superq/promauto
branch
2 times, most recently
from
e3aea68 to
86b0c35
Compare
siavashs
approved these changes
Oct 29, 2025
siavashs
reviewed
Oct 29, 2025
Contributor
siavashs
left a comment
siavashs
left a comment
There was a problem hiding this comment.
There are still CI failures which are related to tests passing a nil registry.
Member
Author
|
Yea, there are a bunch of bad registry implementations here. I'll see what I can fix. |
SuperQ
force-pushed
the
superq/promauto
branch
from
86b0c35 to
2ff847a
Compare
Member
Author
|
@siavashs, let me know what you think of my solutions to the nil registry issues. |
Migrate metrics to use promauto to avoid forgotten metric registration. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/promauto
branch
from
2ff847a to
67bd426
Compare
holger-waschke
pushed a commit
to holger-waschke/alertmanager
that referenced
this pull request
Nov 1, 2025
Migrate metrics to use promauto to avoid forgotten metric registration. Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Holger Waschke <holger.waschke@dvag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate metrics to use promauto to avoid forgotten metric registration.