Skip to content

Synchronize common files from prometheus/prometheus#5183

Merged
SuperQ merged 1 commit intomainfrom
repo_sync
Apr 22, 2026
Merged

Synchronize common files from prometheus/prometheus#5183
SuperQ merged 1 commit intomainfrom
repo_sync

Conversation

@prombot
Copy link
Copy Markdown
Contributor

@prombot prombot commented Apr 20, 2026

Propagating changes from prometheus/prometheus default branch.

Source can be found here.

Summary by CodeRabbit

  • Chores
    • Removed configurable architecture exclusion controls from the build system. All supported architectures will now be unconditionally built, published, tagged, and included in container manifests with every release. This ensures consistent multi-architecture coverage across all releases.

Signed-off-by: prombot <prometheus-team@googlegroups.com>
@prombot prombot requested a review from a team as a code owner April 20, 2026 18:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 45a761ba-1cc9-42e6-9c5c-7fbd02708a69

📥 Commits

Reviewing files that changed from the base of the PR and between db46b3e and 49b6be2.

📒 Files selected for processing (1)
  • Makefile.common
💤 Files with no reviewable changes (1)
  • Makefile.common

📝 Walkthrough

Walkthrough

The pull request removes exported exclusion control variables (DOCKERFILE_ARCH_EXCLUSIONS and DOCKER_REGISTRY_ARCH_EXCLUSIONS) and their associated helper functions from Makefile.common, eliminating conditional skips for specific Docker architecture combinations during build, publish, tag, and manifest creation operations.

Changes

Cohort / File(s) Summary
Makefile.common Docker architecture exclusion cleanup
Makefile.common
Removed exported exclusion variables and helper function definitions (dockerfile_arch_is_excluded, registry_arch_is_excluded), along with all conditional continue branches that previously skipped Docker build, publish, tag, and manifest operations for excluded architecture/registry combinations. Architecture loops now unconditionally include all defined architectures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • SuperQ
  • TheMeier
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Synchronize common files from prometheus/prometheus' accurately describes the main change of syncing common files from an upstream repository.
Description check ✅ Passed The description is minimal but adequate for a sync PR, explaining it propagates changes from upstream and providing the source script reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch repo_sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SuperQ SuperQ merged commit 44fb4e7 into main Apr 22, 2026
7 checks passed
@SuperQ SuperQ deleted the repo_sync branch April 22, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants