Release v0.32.1-rc.0#5192
Closed
SoloJacobs wants to merge 5 commits intoprometheus:mainfrom
Closed
Conversation
This makes it so `make` will no longer skip targets, if files such as `ui/app/all` exist. More importantly, it will stop this from comming up in AI code reviews. Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
In previous commit, I replaced the dockerized `npm` builds with one that runs locally. This was necessary to build our our `UI` via `promu`. This commit adds back the capability to use `docker` to build our UI. Moreover, it introduces two new capabilities: * `podman` can be used to build `elm`. * `CA_BUNDLE` can be used to to pass a certificate bundle into the container. Fixes: prometheus#2848 Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
In prometheus#5113 I removed the build artifacts from our source repo. This complicated the packaging process for downstream maintainers significantly. We will still not check the artifacts into our repo directly, since this is a burden to the review process and opens us up to attacks such as the https://en.wikipedia.org/wiki/XZ_Utils_backdoor . Instead we provide two new mechanisms to obtain the artifacts: * alertmanager-web-ui-(file <VERSION).tar.gz will provide the `dist` folder needed for calling `make build`. * We will upload artifacts via actions/upload-artifact. These can then be easily retrieved for 90 days using `gh`. Finally, this commit also ensures that `ui/app/dist` is always available during build steps. The reason is that caching `npm` dependencies is not sufficient: `Elm` will download its files again anyway, since it stores them in `~/.elm`. This causes unnecessary network calls. Technical approach: * By moving the validation `.build_stamp` to `dist/`, we don't have to upload that file seperately. `embed` will exclude that file. * Storing artifacts in `.tarballs` is our method for including files in the release. This approach was directly taken from `prometheus/prometheus`. Relates-to: prometheus#5173 Fixes: prometheus#5163 Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
…us#5179) * Fix bug in dispatching to contended route * Add metrics for dispatching to contended routes * Add test about dispatching to contended routes * Skip requiring retries > 0 if a single concurrent goroutine is run Signed-off-by: Guido Trotter <ultrotter@gmail.com> Co-authored-by: Guido Trotter <guido@hudson-trading.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Add CHANGELOG entries. Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR restructures the CI/CD pipeline to produce and reuse prebuilt UI assets across jobs, adds dispatcher metrics to track CAS retry contention in alert aggregation, updates the UI build system for containerized execution, and bumps the version to Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores