Only find MAC address if no command-line flag value given#638
Only find MAC address if no command-line flag value given#638stuartnelson3 merged 3 commits intomasterfrom
Conversation
Defaulting to the machine's MAC address fails sometimes fails and causes a panic. Allow the user to specify custom address to skip this so they can run AlertManager.
stuartnelson3
force-pushed
the
delay-check-for-MAC
branch
from
fe6d29c to
11865c1
Compare
brancz
left a comment
brancz
left a comment
There was a problem hiding this comment.
just a small typo and my thought on -mesh.hardware-address, but that would be a breaking change so we should think about it a bit more
README.md
Outdated
| - `-mesh.nickname` string: peer nickname (default "<machine-hostname>") | ||
| - `-mesh.peer` value: initial peers (may be repeated) | ||
| - `-mesh.nickname` string: mesh peer nickname (default "<machine-hostname>") | ||
| - `-mesh.peer` value: initial initial peers (may be repeated) |
README.md
Outdated
| `-mesh.*` flags. | ||
|
|
||
| - `-mesh.hardware-address` string: MAC address, i.e. mesh peer ID (default "<hardware-mac-address>") | ||
| - `-mesh.hardware-address` string: mesh peer ID (default "<hardware-mac-address>") |
There was a problem hiding this comment.
I've thought about this before and was thinking that we should probably change this to -mesh.peer-id and have it default to the mac address, but not call it hardware address.
|
Sounds good. I can leave this here and we can discuss the breaking change, and if we want to then add an alternative to the mac address as a default. |
|
If we are reluctant to have a breaking change now, let's just merge this with the functional change but without the flag change. But perhaps we are not worried about breaking changes at this pre-1.0 point? |
|
I think it's a valid point that this is |
|
It's not that I'm reluctant to the breaking change, I just want to agree on it first 🙂 |
|
I think a breaking change is okay, this feature is marked experimental and I can't imagine too many people setting this currently. On the naming, this is very close to |
|
I think |
|
The naming is similar, but I say since it's experimental, we can change if we get user complaints. I'll figure out why the tests are failing and wait for a thumb from someone. |
|
lgtmog |
* Add dockerfile for ppc64le and related changes * Pass the fill file as DOCKEFILE * Add the dockerfile name to build msg
5 participants
Defaulting to the machine's MAC address fails
sometimes fails and causes a panic. Allow the user to
specify custom address to skip this so they can
run AlertManager.
Addresses #582
@beorn7 @brancz @fabxc this is more or less a quick fix so that users can manually enter something while we decide how to handle this.