Skip to content

HTTP probe does not pass target dns name into "Host" request header #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CompileNix wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HTTP probe does not pass target dns name into "Host" request header #1303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions prober/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,6 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr
httpConfig.Method = "GET"
}

origHost := targetURL.Host
if ip != nil {
// Replace the host field in the URL with the IP we resolved.
if targetPort == "" {
Expand Down Expand Up @@ -430,7 +429,7 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr
level.Error(logger).Log("msg", "Error creating request", "err", err)
return
}
request.Host = origHost
request.Host = targetHost
request = request.WithContext(ctx)

for key, value := range httpConfig.Headers {
Expand Down