Skip to content

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Nov 14, 2025

Signed-off-by: Kemal Akkoyun kemal.akkoyun@datadoghq.com

Our branch protection rules our tied to the versions, this could create problems whenever we update the Go versions.

OLD
Screenshot 2025-11-14 at 18 42 52

NEW
Screenshot 2025-11-14 at 18 55 45

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun kakkoyun force-pushed the stabilize_version_names branch from bef11b1 to 9962bfc Compare November 14, 2025 17:52
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Naming is hard, what about stable-1? (:

"version": "1.25"
},
{
"label": "oldstable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "oldstable",
"label": "stable-1",

@kakkoyun
Copy link
Member Author

Thank you!

Naming is hard, what about stable-1? (:

I chose these names because they are already used in several other places in the ecosystem. e.g. actions/setup-go

@bwplotka
Copy link
Member

Alrighty, I trust you on this (:

@bwplotka bwplotka merged commit 5d937cd into prometheus:main Nov 24, 2025
8 checks passed
@kakkoyun kakkoyun deleted the stabilize_version_names branch November 24, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants