Add stable Metrics class to decouple consumers from protobuf version#1873
Merged
zeitlinger merged 1 commit intomainfrom Feb 13, 2026
Merged
Add stable Metrics class to decouple consumers from protobuf version#1873zeitlinger merged 1 commit intomainfrom
zeitlinger merged 1 commit intomainfrom
Conversation
The generated protobuf Metrics.java lives in a versioned package that changes every protobuf release, requiring import updates in all consumer files. Introduce a stable extending class in the version-free package so consumers import from a single stable location. On protobuf upgrades only the extends clause in the stable class changes, handled automatically by generate-protobuf.sh. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Member
Author
|
approved by @dhoard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metrics.javain the version-free...generatedpackage that extends the versioned generated class, so consumer code no longer needs import updates on protobuf upgrades.generate-protobuf.shto make the generated class extensible (finalremoved, constructorprotected) and read the old package from the stable class'sextendsclause.@SuppressWarnings("NonCanonicalType")for Error Prone compatibility.Test plan
mise run buildpasses (all 54 modules)mise run test -pl prometheus-metrics-exposition-formatspasses (47 tests)mise run lint:super-linterpasses