Adding info for the java runtime name #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@brian-brazil mind to take a look here ? |
brian-brazil
reviewed
Feb 7, 2018
Contributor
There was a problem hiding this comment.
This line is getting a bit long, can you wrap it?
Contributor
Author
There was a problem hiding this comment.
@brian-brazil sure! will also update the javadoc, with the new value ;-)
matzew
force-pushed
the
java_runtime_name
branch
from
a07fb7d to
6c7b853
Compare
Contributor
Author
|
@brian-brazil thanks for the review, I've wrapped the line |
Contributor
|
Thanks! |
This was referenced Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we get the following on the
jvm_infoSee:
But we do not get info if running on OpenJDK or not, hence adding the
java.runtime.nameproperty to the metrics. Result w/ the PR: