Skip to content

Conversation

@shark-horse
Copy link
Contributor

Using one object namesCollectorsLock to lock both names / collectors maps. Using a seperate object instead of one of the maps just to prevent confusion.

Stack trace which I previously encountered with version 0.6.0:

java.util.ConcurrentModificationException
	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)
	at java.util.HashMap$EntryIterator.next(HashMap.java:1479)
	at java.util.HashMap$EntryIterator.next(HashMap.java:1477)
	at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.includedCollectorIterator(CollectorRegistry.java:156)
	at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.<init>(CollectorRegistry.java:146)
	at io.prometheus.client.CollectorRegistry.filteredMetricFamilySamples(CollectorRegistry.java:134)
	at com.procentive.yawl.logic.metrics.prometheus.MetricFamilySamplesIterable.getEnumeration(MetricFamilySamplesIterable.java:59)
	at com.procentive.yawl.logic.metrics.prometheus.MetricFamilySamplesIterable.iterator(MetricFamilySamplesIterable.java:41)
	at com.procentive.yawl.logic.metrics.prometheus.MetricFamilySamplesAssertions.reportSamples(MetricFamilySamplesAssertions.java:94)
	at com.procentive.yawl.logic.metrics.prometheus.MetricFamilySamplesAssertions.assert_hasMetrics(MetricFamilySamplesAssertions.java:41)

@brian-brazil
Copy link
Contributor

Can you add the DCO please?

@shark-horse
Copy link
Contributor Author

shark-horse commented Aug 14, 2019

@brian-brazil Sorry, I don't see anything in this repo about what the agreement is for this repo. Can you please confirm what I would be agreeing to? The prometheus/prometheus wiki says says it's the Developer Certificate of Origin, but this repo says nothing about it that I found.

@brian-brazil
Copy link
Contributor

Yes, it's that.

Using one object (namesCollectorsLock) to lock both names / collectors maps. Using a seperate object just to prevent confusion.

Signed-off-by: Jason Young <jason.young@procentive.com>
@shark-horse
Copy link
Contributor Author

Thanks; done!

@brian-brazil brian-brazil merged commit 8b0c045 into prometheus:master Aug 14, 2019
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants