Add a class cast check to avoid ClassCastException #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX #504 Signed-off-by: Christophe TARDELLA <christophe.tardella@gmail.com>
brian-brazil
reviewed
Oct 7, 2019
| } | ||
| } | ||
|
|
||
| protected List<GarbageCollectorMXBean> getGarbageCollectorMXBeans() { |
Contributor
There was a problem hiding this comment.
Why did you add this function?
Contributor
Author
|
I added this function to be able to test what I coded. Otherwise I don't
know how to mock ManagementFactory.getGarbageCollectorMXBeans().
…On Mon, Oct 7, 2019 at 12:33 PM Brian Brazil ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
simpleclient_hotspot/src/main/java/io/prometheus/client/hotspot/MemoryAllocationExports.java
<#505 (comment)>
:
> @@ -97,4 +99,8 @@ private static long getAndSet(Map<String, Long> map, String key, long value) {
return last == null ? 0 : last;
}
}
+
+ protected List<GarbageCollectorMXBean> getGarbageCollectorMXBeans() {
Why did you add this function?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#505?email_source=notifications&email_token=AAJADRQ5XWGI7MP4MQWFU6LQNMF7BA5CNFSM4I6BFYX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHB2WGI#pullrequestreview-298035993>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJADRXNHREYJAWPKP7FCXTQNMF7BANCNFSM4I6BFYXQ>
.
|
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #504
I added the method getGarbageCollectorMXBeans to be able to test my modifications (otherwise I don't know how to fake ManagementFactory.getGarbageCollectorMXBeans()).