Pin tins dependency for JRuby 9.1
#311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of `tins` adds a dependency on `bigdecimal`, which causes JRuby to fetch and build it rather than using its built-in version. This fails on JRuby 9.1, so we need to handle that version specifically. This gets CI back to green. Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Collaborator
|
Errrmmmm.... What is The gem description seems very unspecific... And I may be being thick here, but pretty sure our tests runs without it... Can we just get rid of the gem instead of this JRuby pinning? |
Collaborator
|
Apparently |
Member
Author
|
Closing in favour of #312. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
tinsadds a dependency onbigdecimal, which causes JRuby to fetch and build it rather than using its built-in version. This fails on JRuby 9.1, so we need to handle that version specifically.This gets CI back to green.
Once this is merged, I'm going to cut a patch release to finally get rid of the annoying warning that we emit on Ruby 3.3.