fix(http_config): fix client cert rotation when no CA is configured#908
Merged
Conversation
enabling client cert/key hot-reloading. However, RoundTrip() still unconditionally called updateRootCA on every transport rebuild. With no CA data it returned false, and the code called settings.CA.Description() on nil, panicking (prometheus/prometheus#16622). still failed with "unable to use specified CA cert: none configured", so cert rotation never actually worked without a CA. Skip the updateRootCA call when settings.CA is nil so transport rebuilds succeed and client cert rotation works without a CA as See prometheus/prometheus@a116078 for a reproducer on Prometheus Signed-off-by: Ayoub Mrini <ayoubmrini424@gmail.com>
roidelapluie
approved these changes
May 20, 2026
This was referenced May 20, 2026
Merged
Merged
Merged
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
May 20, 2026
Make sure it doesn't panic AND doesn't perma-fail. Point prometheus/common to a patched version that contains prometheus/common#908 Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
May 20, 2026
Make sure it doesn't panic AND doesn't perma-fail. Point prometheus/common to a patched version that contains prometheus/common#908 Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
May 20, 2026
Make sure it doesn't panic AND doesn't perma-fail. Point prometheus/common to a patched version that contains prometheus/common#908 Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
May 20, 2026
Make sure it doesn't panic AND doesn't perma-fail. Point prometheus/common to a patched version that contains prometheus/common#908 Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#707 started using tlsRoundTripper even when no CA is configured,
enabling client cert/key hot-reloading. However, RoundTrip() still
unconditionally called updateRootCA on every transport rebuild. With
no CA data it returned false, and the code called
settings.CA.Description() on nil, panicking (prometheus/prometheus#16622).
#792 fixed the panic by returning an error instead, but every rebuild
still failed with "unable to use specified CA cert: none configured",
so cert rotation never actually worked without a CA.
Skip the updateRootCA call when settings.CA is nil so transport
rebuilds succeed and client cert rotation works without a CA as
#707 intended.
See prometheus/prometheus@a116078 for a reproducer on Prometheus