Conversation
Member
Author
|
Changed the first thing I could find to nitpick. |
Member
Author
|
Heh, DCO is an issue with in-web changes. |
Try to trigger rebuild; might fix #1045 Signed-off-by: Richard Hartmann <richih@debian.org>
brian-brazil
reviewed
Jun 4, 2018
|
|
||
| The short answer is to instrument everything. Every library, subsystem and | ||
| service should have at least a few metrics to give you a rough idea of how it is | ||
| service should expose at least a few metrics to give you a rough idea of how it is |
Contributor
There was a problem hiding this comment.
Instrumentation and exposition are separate concerns, libraries should not be exposing metrics. They should register them in a registry.
Signed-off-by: Richard Hartmann <richih@debian.org>
Member
Author
|
This has been fixed by our world-visible host. |
Member
Author
|
Erm, wrong PR. Disregard my confusion. |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
Changed URL structure of how-to/get-started. Fixed s/sample/example/ bug introduced in DITA fixed categories
beorn7
approved these changes
Nov 28, 2019
Member
|
DCO is fine as per human inspection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to trigger rebuild; might fix #1045