Skip to content

Use draw.io for architecture diagram#1102

Merged
juliusv merged 1 commit intoprometheus:masterfrom
lucperkins:lperkins/svg-source
Jul 6, 2018
Merged

Use draw.io for architecture diagram#1102
juliusv merged 1 commit intoprometheus:masterfrom
lucperkins:lperkins/svg-source

Conversation

@lucperkins
Copy link
Contributor

No description provided.

Signed-off-by: lucperkins <lucperkins@gmail.com>
@lucperkins lucperkins requested a review from juliusv July 6, 2018 22:34
@juliusv
Copy link
Member

juliusv commented Jul 6, 2018

👍 Awesome, thanks!

Is it intentional that the new one has serif fonts, while the old one was completely sans serif? I don't have a big opinion either way.

@lucperkins
Copy link
Contributor Author

lucperkins commented Jul 6, 2018

@juliusv Hmmm. I'm not really seeing any serif fonts. The file_sd in the Service Discovery block is monospaced because that's code, but besides that everything is in the Lato font to match the docs.

@juliusv
Copy link
Member

juliusv commented Jul 6, 2018

@lucperkins Huh weird, it looks like this to me in GitHub and also when I import the XML into draw.io:

serifs

Maybe just my browser though. Merging to see what it'll look like on the final site :)

@juliusv juliusv merged commit c7c79d3 into prometheus:master Jul 6, 2018
@juliusv
Copy link
Member

juliusv commented Jul 6, 2018

Hmm, now it's on the live site and still has serifs for me, while the old one was perfectly sans-serifed.

Oh well, maybe some explicit font stuff is missing, but it's getting late here. Might look into it myself soon since now we have the XML source and a free tool - thanks! :)

@lucperkins
Copy link
Contributor Author

@juliusv Sigh. It looks like it depends which fonts are available on the reader's machine (rather than being embedded within the SVG itself). I'll see if draw.io has different export options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants