Skip to content

Update AlertManager configuration page for AM v0.18#1354

Merged
brian-brazil merged 3 commits intoprometheus:masterfrom
simonpasquier:update-opsgenie-config
Jul 30, 2019
Merged

Update AlertManager configuration page for AM v0.18#1354
brian-brazil merged 3 commits intoprometheus:masterfrom
simonpasquier:update-opsgenie-config

Conversation

@simonpasquier
Copy link
Member

Follow-up of prometheus/alertmanager#1863. It should be merged only after AlertManager v0.18 is released. cc @bwplotka

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@simonpasquier simonpasquier force-pushed the update-opsgenie-config branch 2 times, most recently from 8001704 to 76e37de Compare June 24, 2019 12:11
@simonpasquier simonpasquier changed the title Update OpsGenie configuration for AM v0.18 Update AlertManager configuration page for AM v0.18 Jun 24, 2019
### `<responder>`

```yaml
# One of these fields should be defined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly or at least?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's "exactly" but @bwplotka could confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They say nothing about this stricly so I would assume `exactly.

 Either id or name of each responder should be provided.You can refer below for example values.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
See prometheus/alertmanager#1931

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier force-pushed the update-opsgenie-config branch from 76e37de to 0f52c55 Compare July 10, 2019 12:40
@simonpasquier simonpasquier requested a review from bwplotka July 10, 2019 14:26
@simonpasquier
Copy link
Member Author

@brian-brazil ok to merge?

@brian-brazil brian-brazil merged commit a5e03a4 into prometheus:master Jul 30, 2019
@simonpasquier simonpasquier deleted the update-opsgenie-config branch July 30, 2019 13:13
@simonpasquier
Copy link
Member Author

Thanks!

aylei added a commit to aylei/docs that referenced this pull request Oct 28, 2019
* dev, 3.0: Add tkctl user guide

Signed-off-by: Aylei <rayingecho@gmail.com>

* Address review comments

Signed-off-by: Aylei <rayingecho@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Apply change to 3.0

Signed-off-by: Aylei <rayingecho@gmail.com>

* dev, v3.0: improve language and align with Chinese version
eightnoneone pushed a commit to eightnoneone/docs that referenced this pull request Apr 20, 2020
* Update OpsGenie configuration for AM v0.18
* Fix PagerDuty image configuration

See prometheus/alertmanager#1931

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants