Skip to content

Add Splunk(read and write) to list of remote storages#1365

Merged
brian-brazil merged 2 commits intoprometheus:masterfrom
kebe7jun:master
Jun 18, 2019
Merged

Add Splunk(read and write) to list of remote storages#1365
brian-brazil merged 2 commits intoprometheus:masterfrom
kebe7jun:master

Conversation

@kebe7jun
Copy link
Contributor

Ropee is a prometheus remote storage adapter for splunk designed by @DaoCloud.

Signed-off-by: KEBE <kebe.liu@daocloud.io>
@brian-brazil
Copy link
Contributor

Thanks for sharing. It looks like this is a superset of the currently listed one, so you can replace it.

Your README has a password on the commandline, can you move it somewhere more secure?

There's also no need for read_recent to be true.

Signed-off-by: KEBE <kebe.liu@daocloud.io>
@kebe7jun
Copy link
Contributor Author

Thanks for your comment, I have updated my repo's README and removed old Splunk adaptor.

@brian-brazil
Copy link
Contributor

You're still taking a password on the command line, both in the docker example and the adapter itself.

@kebe7jun
Copy link
Contributor Author

You're still taking a password on the command line, both in the docker example and the adapter itself.

@brian-brazil
I have removed the auth from command line for secure.
https://github.com/kebe7jun/ropee#configuring-prometheus

@brian-brazil
Copy link
Contributor

I still see it in the code: https://github.com/kebe7jun/ropee/blob/master/main.go#L67

We ask that there's no obvious security issues before listing something here, which basically means not exposing passwords on the command line.

@kebe7jun
Copy link
Contributor Author

Sorry about that, I have removed the password option from command.
commit: kebe7jun/ropee@5ae55ed

@brian-brazil brian-brazil merged commit 07a61ee into prometheus:master Jun 18, 2019
@brian-brazil
Copy link
Contributor

Thanks!

aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
* v2.1, v3.0, dev: add benchmark docs to the website

* lowercase words

* improve wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants