Add Splunk(read and write) to list of remote storages#1365
Add Splunk(read and write) to list of remote storages#1365brian-brazil merged 2 commits intoprometheus:masterfrom kebe7jun:master
Conversation
Signed-off-by: KEBE <kebe.liu@daocloud.io>
|
Thanks for sharing. It looks like this is a superset of the currently listed one, so you can replace it. Your README has a password on the commandline, can you move it somewhere more secure? There's also no need for read_recent to be true. |
Signed-off-by: KEBE <kebe.liu@daocloud.io>
|
Thanks for your comment, I have updated my repo's README and removed old Splunk adaptor. |
|
You're still taking a password on the command line, both in the docker example and the adapter itself. |
@brian-brazil |
|
I still see it in the code: https://github.com/kebe7jun/ropee/blob/master/main.go#L67 We ask that there's no obvious security issues before listing something here, which basically means not exposing passwords on the command line. |
|
Sorry about that, I have removed the password option from command. |
|
Thanks! |
* v2.1, v3.0, dev: add benchmark docs to the website * lowercase words * improve wording
Ropee is a prometheus remote storage adapter for splunk designed by @DaoCloud.