Skip to content

Add link to openstack_client_exporter#1397

Merged
brian-brazil merged 1 commit intoprometheus:masterfrom
ctrlaltdel:openstack_client_exporter
Aug 6, 2019
Merged

Add link to openstack_client_exporter#1397
brian-brazil merged 1 commit intoprometheus:masterfrom
ctrlaltdel:openstack_client_exporter

Conversation

@ctrlaltdel
Copy link
Contributor

No description provided.

@ctrlaltdel ctrlaltdel force-pushed the openstack_client_exporter branch from a3c84b9 to 99469b4 Compare July 19, 2019 13:06
@brian-brazil
Copy link
Contributor

How does this differ from the openstack exporter we already list, and have you talked to the listed one's maintainers about changes you'd like to make?

@ctrlaltdel
Copy link
Contributor Author

ctrlaltdel commented Jul 20, 2019 via email

@brian-brazil
Copy link
Contributor

Okay, so this is more of a blackbox exporter. Can you put Blackbox in the entry name?

openstack_client_spawn_timing and friends should include their unit in the metric name, openstack_client_spawn_success and openstack_client_object_store_success should not have the error as a label - that's a matter for logs.

Signed-off-by: Francois Deppierraz <francois@ctrlaltdel.ch>
@ctrlaltdel ctrlaltdel force-pushed the openstack_client_exporter branch from 99469b4 to 9c60c83 Compare August 6, 2019 14:49
@ctrlaltdel
Copy link
Contributor Author

ctrlaltdel commented Aug 6, 2019

Okay, so this is more of a blackbox exporter. Can you put Blackbox in the entry name?

Yep, done.

openstack_client_spawn_timing and friends should include their unit in the metric name

Good point, I'll look into releasing a new version with s/_timing/_timestamp_seconds/.

openstack_client_spawn_success and openstack_client_object_store_success should not have the error as a label - that's a matter for logs.

Conceptually, I agree. However, it is a pretty convenient way to create annotations in a grafana dashboard with the reason why something failed.

@brian-brazil brian-brazil merged commit 12da819 into prometheus:master Aug 6, 2019
@brian-brazil
Copy link
Contributor

Conceptually, I agree. However, it is a pretty convenient way to create annotations in a grafana dashboard with the reason why something failed.

Doing logging in a metrics system can easily lead to both cardinality and semantic issues, it should be avoided.

aylei added a commit to aylei/docs that referenced this pull request Oct 28, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
eightnoneone pushed a commit to eightnoneone/docs that referenced this pull request Apr 20, 2020
Signed-off-by: Francois Deppierraz <francois@ctrlaltdel.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants