Add Pact Broker Exporter#1419
Merged
brian-brazil merged 3 commits intoprometheus:masterfrom Sep 5, 2019
pperzyna:master
Merged
Add Pact Broker Exporter#1419brian-brazil merged 3 commits intoprometheus:masterfrom pperzyna:master
brian-brazil merged 3 commits intoprometheus:masterfrom
pperzyna:master
Conversation
Signed-off-by: Piotr Perzyna <piotr.perzyna@gmail.com>
Contributor
|
Can you add the DCO and keep it sorted please? You should be using MustNewConstMetric for all your metrics, as is it won't handle pacts disappearing correctly. |
Signed-off-by: Piotr Perzyna <piotr.perzyna@gmail.com>
Contributor
Author
|
@brian-brazil It took me a while to fulfill the DCO and moved to MustNewConstMetric, but it is done. |
brian-brazil
reviewed
Sep 4, 2019
Signed-off-by: Piotr Perzyna <piotr.perzyna@gmail.com>
Contributor
Author
|
@brian-brazil done |
Contributor
|
Thanks! |
eightnoneone
pushed a commit
to eightnoneone/docs
that referenced
this pull request
Apr 20, 2020
* Add Pact Broker Exporter Signed-off-by: Piotr Perzyna <piotr.perzyna@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.