Updates to the logos section of the landing page#1439
Merged
Conversation
Latency.at is dad, sadly, as we know. I'm not sure who uda100.com even was. The domain is still registered (by Alibaba Cloud), but connections time out. The logo doesn't exist on the internet, either. Signed-off-by: beorn7 <beorn@grafana.com>
I have verified that HTTPS is actually served for all of these. Signed-off-by: beorn7 <beorn@grafana.com>
juliusv
reviewed
Sep 16, 2019
content/index.html
Outdated
| <a href="https://www.eurotech.com/"><img src="assets/company-logos/Eurotech.png"/></a> | ||
| <a href="https://www.fosdem.org/"><img src="assets/company-logos/Fosdem.png"/></a> | ||
| <a href="https://giantswarm.io/"><img src="assets/company-logos/giantswarm.png"/></a> | ||
| <a href="https://grafana.com"><img src="assets/company-logos/grafana.png"/></a> |
Member
There was a problem hiding this comment.
This one's indented inconsistently.
Member
Author
There was a problem hiding this comment.
My naughty Emacs introduced a tab here. Untabify helped…
Member
|
👍 besides nit |
I got permissions from my employer to add the logo. Signed-off-by: beorn7 <beorn@grafana.com>
beorn7
force-pushed
the
beorn7/landing
branch
from
28e7ccf to
0592aab
Compare
Member
|
👍 |
Contributor
The reason for them originally being there no longer applies, so I think it would make sense to make them less prominent. |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
…etheus#1439) * reference/configuration: add a new variable tidb_scatter_region * remove extra lines * improve wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In different news, I kind of think the use of logos on the front page is outdated. We don't have to prove anything anymore. An approach to have a separate section of linked case studies similar to kubernetes.io might make more sense. However, that's a longer discussion (topic for the dev summit?), and while the logos are still there, we should keep them up to date.