Add link to Signalilo in integrations page#1589
Add link to Signalilo in integrations page#1589roidelapluie merged 1 commit intoprometheus:masterfrom
Conversation
brian-brazil
left a comment
brian-brazil
left a comment
There was a problem hiding this comment.
You're taking secrets on the command line, which is not secure.
| * [AWS SNS](https://github.com/DataReply/alertmanager-sns-forwarder) | ||
| * [DingTalk](https://github.com/timonwong/prometheus-webhook-dingtalk) | ||
| * [GELF](https://github.com/b-com-software-basis/alertmanager2gelf) | ||
| * [Icinga2 (Signalilo)](https://github.com/vshn/signalilo): creates services in Icinga2 based on received notifications |
There was a problem hiding this comment.
Just saying Icinga2 is enough
There was a problem hiding this comment.
You don't need the description either
We're aware of that and pass the secrets as environment vars from a Kubernetes secret in the Helm chart. Unfortunately |
|
Let me know when that's resolved, our policy is not to list integrations with obvious security issues. |
|
Can you elaborate on what you consider obvious security issues when it comes to handling secret arguments? |
|
You're allowing secrets on the command line. |
|
I was asking more generally as to what practices you consider obvious security issues, since I wasn't able to find any guidelines after a quick look in the repository. For example, Is it OK to pass secrets in environment variables? In config files? |
|
Both those methods are okay (though environment variables have their risks). |
|
Maybe we should also wait for vshn/signalilo#15 to be resolved to people can use this effectively? |
|
There's no documentation requirement, as long as the code isn't obviously broken that's good enough in that regard. |
|
https://github.com/vshn/signalilo/blob/master/webhook/icinga.go#L20 -> is that an internal repo? |
|
|
@roidelapluie no idea how we missed this during the opensourcing process, the only reason why the github build works is that |
beorn7
added
the
exporters and integrations
|
The description still needs to be removed. Thanks. |
|
@roidelapluie Can you elaborate on which description needs to be removed? I don't quite follow. |
| * [AWS SNS](https://github.com/DataReply/alertmanager-sns-forwarder) | ||
| * [DingTalk](https://github.com/timonwong/prometheus-webhook-dingtalk) | ||
| * [GELF](https://github.com/b-com-software-basis/alertmanager2gelf) | ||
| * [Icinga2](https://github.com/vshn/signalilo): creates services in Icinga2 based on received notifications |
There was a problem hiding this comment.
| * [Icinga2](https://github.com/vshn/signalilo): creates services in Icinga2 based on received notifications | |
| * [Icinga2](https://github.com/vshn/signalilo) |
There was a problem hiding this comment.
Oh ok, I've adjusted that in the latest version of the commit.
Signalilo is a tool to convert Alertmanager notifications to Icinga2 services. Signed-off-by: Simon Gerber <simon.gerber@vshn.ch>
|
Thanks. now only pending vshn/signalilo#17 |
|
I actually missed my last comment when merging. I hope that you will soon be able to address vshn/signalilo#17 |
4 participants
This is just a small change adding our tool "Signalilo" which converts received notifications into Icinga2 services to the list of webhook-based integrations.