Add alertmanager-gotify-bridge project to integrations#1717
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Sep 19, 2020
DRuggeri:signedoff
Merged
Add alertmanager-gotify-bridge project to integrations#1717brian-brazil merged 1 commit intoprometheus:masterfrom DRuggeri:signedoff
brian-brazil merged 1 commit intoprometheus:masterfrom
DRuggeri:signedoff
Conversation
Signed-off-by: Daniel Ruggeri <druggeri@primary.net>
Contributor
|
Thanks for your PR. This takes a secret on the command line, which is not secure. Can you fix that please, and then we can list it? |
Contributor
Author
|
Ah, yes, that's right. I've fixed that now in DRuggeri/alertmanager_gotify_bridge@18914ae |
simonpasquier
approved these changes
Aug 12, 2020
Contributor
Author
|
Good to merge? |
Contributor
|
Thanks! The readme makes it seem as though the flag would work, which is a bit confusing. |
Contributor
Author
|
Oops - thanks, @brian-brazil. Fixed that in the README just now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add another webhook receiver for alertmanager integrations