Add Vector to tools that export Prometheus metrics#1808
Merged
roidelapluie merged 1 commit intoprometheus:masterfrom Sep 7, 2021
Merged
Add Vector to tools that export Prometheus metrics#1808roidelapluie merged 1 commit intoprometheus:masterfrom
roidelapluie merged 1 commit intoprometheus:masterfrom
Conversation
Contributor
|
Can you add the DCO? https://vector.dev/docs/reference/sinks/prometheus_remote_write/ also says that Prometheus ingests remote write, which is incorrect. Can you fix that please? |
Vector has both a Prometheus source and sink and a `remote_write` source and sink. Signed-off-by: James Turnbull <james@lovedthanlost.net>
Contributor
Author
|
The DCO is fixed. |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector has both a Prometheus source and sink and a
remote_writesource and sink.@brian-brazil
Signed-off-by: James Turnbull james@lovedthanlost.net