Skip to content

Added Monitoring Studio X as a third-party software exposing Promethe…#1977

Merged
RichiH merged 2 commits intoprometheus:masterfrom
iguitton:iguitton-add-studiox-as-third-party-software
Jul 1, 2021
Merged

Added Monitoring Studio X as a third-party software exposing Promethe…#1977
RichiH merged 2 commits intoprometheus:masterfrom
iguitton:iguitton-add-studiox-as-third-party-software

Conversation

@iguitton
Copy link
Contributor

@iguitton iguitton commented Jun 23, 2021

@RichiH

Added Monitoring Studio X as a third-party software exposing Prometheus metrics

@iguitton iguitton force-pushed the iguitton-add-studiox-as-third-party-software branch from 6083ce6 to e6e7b2a Compare June 23, 2021 09:14
…us Metrics

Signed-off-by: Isabelle Guitton <isabelle@sentrysoftware.com>
@RichiH
Copy link
Member

RichiH commented Jun 23, 2021

Thanks @iguitton !

Taking a quick glance, skm_volume_readrate_bytes_per_second is an anti-pattern; is there any chance to expose the raw values like skm_volume_read_bytes_total so users can use rate() and such in PromQL?

@bertysentry
Copy link

@RichiH: Unfortunately, the PATROL Agent does not expose the underlying raw values of its metrics. We tried to reconstruct the raw values from the rates, but it's a resource-intensive task for the agent when there are thousands of metrics to convert.

We're still doing a lot of automatic units conversions (e.g. the FreeSpace metric is originally expressed in MB, and we convert it to bytes, etc.) but this version of the exporter doesn't reconstruct the raw values from the rate metrics. It's still under consideration for a new version, but it will truly depend on the overall performance of the operation.

@iguitton iguitton force-pushed the iguitton-add-studiox-as-third-party-software branch from e3e1245 to 92882d5 Compare June 24, 2021 07:58
Signed-off-by: Isabelle Guitton <isabelle@sentrysoftware.com>
@iguitton
Copy link
Contributor Author

@RichiH any update?

@RichiH
Copy link
Member

RichiH commented Jul 1, 2021

@bertysentry Rebuilding counters from rates is error-prone. If your upstream were to consider exposing raw values, that would be best.

@iguitton thanks for the poke & PR, merging.

@RichiH RichiH merged commit 7a4bd78 into prometheus:master Jul 1, 2021
@iguitton iguitton deleted the iguitton-add-studiox-as-third-party-software branch October 21, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants