Conversation
The current documentaton for histograms says "Count MUST exclude the +Inf bucket". Looks like this is a type, client libraries include the +Inf buckets in the count. Signed-off-by: Fabian Stäber <fabian@fstab.de>
Member
|
In fact, as probably specified in many locations, the count field must have the same value as the +Inf bucket (and therefore the +Inf bucket is even optional in the old protobuf). It's really weird what has been written here for ages. |
beorn7
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current documentaton for histograms says "Count MUST exclude the +Inf bucket". Looks like this is a type, client libraries include the +Inf buckets in the count.
Signed-off-by: Fabian Stäber fabian@fstab.de