Skip to content

Update support-training.html#2331

Merged
juliusv merged 4 commits intoprometheus:mainfrom
francjp:patch-1
Sep 19, 2023
Merged

Update support-training.html#2331
juliusv merged 4 commits intoprometheus:mainfrom
francjp:patch-1

Conversation

@francjp
Copy link
Contributor

@francjp francjp commented May 16, 2023

Adding OpenNebula as part of the Commercial Support. Since #2330 hasn't been commented yet

Apologies in advance for insisting on this, but perhaps I followed the wrong path to request an addition on the Commercial Support. Is it possible to add OpenNebula as Commercial Support in Prometheus?

Please, if I'm not following the right procedure, let me know if I should do it in another way.

Best regards,

@francjp
Copy link
Contributor Author

francjp commented May 18, 2023

Hello @RichiH is it possible to have an update on this?, thanks!

@RichiH
Copy link
Member

RichiH commented May 25, 2023

The page lists service & support. While it seems that OpenNebula has Prometheus integrations, I couldn't find actual training & support as a primary offering. Could you point me to the right place, please?

@francjp
Copy link
Contributor Author

francjp commented May 25, 2023

The page lists service & support. While it seems that OpenNebula has Prometheus integrations, I couldn't find actual training & support as a primary offering. Could you point me to the right place, please?

Hi @RichiH thanks for your reply.
We have Prometheus integrated on our Enterprise Edition (meaning commercial support included). You can find more information here:

Version 6.6 is the Enterprise edition. Let me know if this is good enough, or if you prefer to link the logo to a specific landing that clarifies this information.

Thanks!

@francjp
Copy link
Contributor Author

francjp commented Jun 5, 2023

Hello @RichiH any update on this?, do you need more information or links for our documentation?

Cheers,

@RichiH
Copy link
Member

RichiH commented Jun 16, 2023

It would be better to have a page which clearly describes the services you provide, yes. NB: We normally require people to have Prometheus-specific support beyond simply hosting it. I wasn't 100% sure from looking at your links.

@francjp
Copy link
Contributor Author

francjp commented Jun 22, 2023

It would be better to have a page which clearly describes the services you provide, yes. NB: We normally require people to have Prometheus-specific support beyond simply hosting it. I wasn't 100% sure from looking at your links.

Hi @RichiH, we do not host any Prometheus instances. We offer Prometheus-specific support as part of the OpenNebula Enterprise Edition. Please check the bottom part on the section "Exclusive Enterprise Features"

https://opennebula.io/subscriptions/#pricing_opennebula

Advanced Monitoring: Novel integration of Prometheus for enterprise monitoring, combined with new Grafana dashboards for optimal observability.

@francjp
Copy link
Contributor Author

francjp commented Jul 14, 2023

Hi @RichiH, sorry to insist on this, but have you had time to look on my last comment?. Is that enough, or do you think we should make any clarification on our page?

Best regards,

@francjp
Copy link
Contributor Author

francjp commented Aug 14, 2023

Hello @RichiH, it's me again. Do you have any update on this?, is it rejected or do you need more info on our side aside the webpage I linked above?: https://opennebula.io/subscriptions/#pricing_opennebula

Best regards,

@francjp
Copy link
Contributor Author

francjp commented Sep 14, 2023

Hello @RichiH and team, I'm still waiting an answer on this open PR. If we cannot be listed, can you clarify the reasons?

I'm seeing that other PR like this one: Adding Cloudraft, was solved without any comment.
As well as this one Add Cloudwise, where I don't see much difference with what we explicitly said on our page about the support we give to Prometheus.

So I would like to check if it's a different criteria, or they have their support in a more explicit way than us.

cc @bwplotka @juliusv (I know that pinging people is not a good practice, but you are involved in the examples I'm pasting here).

In any case, thanks for any clarification you can give to me, to see if there's any solution to this PR.

@juliusv
Copy link
Member

juliusv commented Sep 15, 2023

Hi @francjp thanks for pinging, and sorry for the long wait! It's true that we prefer as much Prometheus-specific information as possible, but also that we have not been strict about this as a requirement for others in the past, so I think it's ok enough as it is. At some point we may want to rethink the entire page since I'm not sure how useful it is now for potential customers. But for now it's ok.

However, we do want to keep the list alphabetically sorted, could you adjust that bit before I merge? Also, please do include the image file in the PR and link to it locally, as we want to be in control of the images we display on the Prometheus website.

@francjp
Copy link
Contributor Author

francjp commented Sep 15, 2023

Hi @juliusv thanks for your reply. I applied the changes requested, hoping everything is ok now. Let me know if you need more info, or if I have to make any other adjustment.

Cheers,

@juliusv
Copy link
Member

juliusv commented Sep 15, 2023

@francjp thank you, it's still missing this part though:

Also, please do include the image file in the PR and link to it locally, as we want to be in control of the images we display on the Prometheus website.

Could you also remove the unrelated extra empty line further down that was introduced in this PR?

Copy link
Contributor Author

@francjp francjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opennebula_cloud_logo_white_bg

Adding the logo locally

@francjp
Copy link
Contributor Author

francjp commented Sep 15, 2023

Hi @juliusv I cannot add the image locally on the folder "Assets", so I'm adding it here, I can change the URL, but it will be different to what you have on the file: https://github.com/prometheus/docs/assets/6509355/eae64100-da30-4ce3-80c4-05362a1d3c66

I'm probably missing something, so I'll appreciate any help.

@juliusv
Copy link
Member

juliusv commented Sep 15, 2023

@francjp Ah yes, that's a bit confusing. Take a look at one of the other PRs for this page, for example: https://github.com/prometheus/docs/pull/2344/files - the file goes under static/commercial-support-logos/ in the repo.

There's also still extra some trailing whitespace that's not related to the new logo, see https://github.com/prometheus/docs/pull/2331/files

Copy link
Contributor Author

@francjp francjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Space and added logo locally

@juliusv
Copy link
Member

juliusv commented Sep 18, 2023

@francjp Thanks, that looks good! The commit adding the logo is missing the Signed-off-by: Francisco Picolini <fpicolini@opennebula.io> line that you have on your other commits, which makes the DCO CI check fail - would you be able to add that (probably you'd have to interactively rebase, edit that one commit message, and then force push).

@francjp
Copy link
Contributor Author

francjp commented Sep 19, 2023

Hi @juliusv I forgot to sign my identity here (I used to have another email for github), so let me know if everything now looks good or I forgot something. Thanks a lot for your patience and your help.

Cheers

@juliusv
Copy link
Member

juliusv commented Sep 19, 2023

@francjp Hmm, I still see the same thing as before - all commits have the DCO signoff, except for the one that adds the logo file. Compare for example ce5f53f and 6f13ed2.

francjp

This comment was marked as duplicate.

Adding OpenNebula as part of the Commercial Support. Since prometheus#2330 hasn't been commented yet

Signed-off-by: Francisco Picolini <fpicolini@opennebula.io>
Signed-off-by: FrancJP <fpicolini@opennebula.io>
Applied changes requested: Respect alphabetic order, and image linked to one of our resources and not another repo

Signed-off-by: Francisco Picolini <fpicolini@opennebula.io>
Signed-off-by: FrancJP <fpicolini@opennebula.io>
Removed empty space on line 177

Signed-off-by: Francisco Picolini <fpicolini@opennebula.io>
Signed-off-by: FrancJP <fpicolini@opennebula.io>
Signed-off-by: FrancJP <fpicolini@opennebula.io>
@francjp
Copy link
Contributor Author

francjp commented Sep 19, 2023

@juliusv I think I finally managed... sorry for the hassle

@juliusv
Copy link
Member

juliusv commented Sep 19, 2023

@francjp Ah drat, I didn't see now(?) that the URL of the picture is still pointing at the remote version, not the local picture. And the trailing whitespace still seems to be there? I can merge this though for now (as the checks pass) and send a quick follow-up fix PR.

@juliusv juliusv merged commit a4320fc into prometheus:main Sep 19, 2023
juliusv added a commit that referenced this pull request Sep 19, 2023
Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv added a commit that referenced this pull request Sep 19, 2023
Signed-off-by: Julius Volz <julius.volz@gmail.com>
@francjp
Copy link
Contributor Author

francjp commented Sep 20, 2023

Thanks @juliusv and apologies for all the hassle. I don't know what happened, since I was following the procedure on signing a commit, so sorry again and many thanks for your help and patience.

@juliusv
Copy link
Member

juliusv commented Sep 20, 2023

@francjp No worries, thanks for your patience with our CI gods as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants